Move to TS #954
Open
Move to TS #954
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… into ts-2 � Conflicts: � types/queries.d.ts
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit c4fda2b:
|
eps1lon
requested changes
May 6, 2021
| @@ -29,12 +33,14 @@ function getCodeFrame(frame) { | |||
|
|
|||
| let rawFileContents = '' | |||
| try { | |||
| rawFileContents = readFileSync(filename, 'utf-8') | |||
| // eslint-disable-next-line @typescript-eslint/no-unsafe-assignment | |||
| rawFileContents = readFileSync?.(filename, 'utf-8') | |||
There was a problem hiding this comment.
This would no longer throw if readFileSync is not callable.
Generally, don't change any runtime when porting to TypeScript. Use type casting instead so that we know where we might want to work on.
fildon
reviewed
May 9, 2021
|
Hi, do you think you can work on these merge conflicts or do you need help? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
Move code to TS
Why:
How:
Checklist:
docs site